[rush] move sharded operation config to its own block #4923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramissennyeydd
requested review from
iclanton,
octogonz,
apostolisms,
D4N14L and
dmichon-msft
as code owners
iclanton
changed the title
iclanton
approved these changes
Sep 16, 2024
common/changes/@microsoft/rush/sennyeya-shard-schema-updates_2024-09-13-22-46.json
Outdated
Show resolved
Hide resolved
iclanton
approved these changes
Sep 17, 2024
common/changes/@microsoft/rush/sennyeya-shard-schema-updates_2024-09-13-22-46.json
Outdated
Show resolved
Hide resolved
…024-09-13-22-46.json Co-authored-by: Ian Clanton-Thuon <iclanton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Followup to @iclanton's comments in #4871. Moving the config for shards to its own object instead of piggybacking onto the collate operation.
As-is this is a breaking change, open to thoughts on how to roll this out safely.
How it was tested
Tested locally against the rush-redis-cobuild-plugin-integration-tests.
Impacted documentation
Schema definitions will need to be updated.